cameraview: remove glflush #22949
Merged
cameraview: remove glflush #22949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can revert 7a3754d if the cpu usage is back to 20% |
|
Do you still want to look into the blocking of glMap, or is this the best we can do? |
|
glmap usually blocking for a few milliseconds, and occasionally more than 10ms, it's ok because it's run in vipc thread, the main thread will not be blocked. |
|
Oh, assumed it was much more than a few ms. Then this is fine. |
|
Weird, I really though CPU usage was lower when I tested this change before. Guess I didn't rebuild properly or something. There must be something else we can do to lower CPU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.